Attention is currently required from: laforge. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmocore/+/43346?usp=email )
Change subject: usb: osmo_libusb_open_claim_interface: print an error when no device was found ...................................................................... Patch Set 1: (1 comment) File src/usb/osmo_libusb.c: https://gerrit.osmocom.org/c/libosmocore/+/43346/comment/485d94ce_39f81e48?usp=email : PS1, Line 583: > do we really need the goto? Doesn the if (!usb_devh) nicely cover what we > need here? Without the goto you will have: """ Cannot set interface altsetting X Failed to find a matching usb device """ The second line would be wrong in the error case, because it found a matching device, but couldn't configure it in the right way. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/43346?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I59d31f80a9d5b6bf7b33ca80f4387748531b4cce Gerrit-Change-Number: 43346 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Comment-Date: Thu, 20 Aug 2026 15:54:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]>
