Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43261?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: sgsn: Fail in obvious way when unexpected ServiceAccept is
received
......................................................................
sgsn: Fail in obvious way when unexpected ServiceAccept is received
since osmo-ttcn3-hacks.git 2ff5b2633a43cecaed75b30b85537d6de3a52c97, the
code doesn't expect to receive a ServiceAccept after SecurityCommand,
ie. osmo-sgsn is wrong. As a result, tests such as
TC_attach_pdp_act_user end up failing with a tGuard timeout waiting for
a RAB ASs Req. The result is confusing since osmo-sgsn actually sends
the RAB Ass Req, but since the unexpected ServiceAccept is first in the
queue, the ttcn3 code doesn't process the RAB Ass Req.
Make the test explicitly fail if something else from RAB Ass Req is in
the queue preventing reading from it.
Change-Id: Ifbb7da1d02c8bde3406a9dd445c03ed140b8c0a3
---
M sgsn/BSSGP_ConnHdlr.ttcn
1 file changed, 9 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/61/43261/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43261?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ifbb7da1d02c8bde3406a9dd445c03ed140b8c0a3
Gerrit-Change-Number: 43261
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
