Attention is currently required from: jolly. dexter has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43302?usp=email )
Change subject: Add missing Pepare Download error handling ...................................................................... Patch Set 1: (1 comment) File src/ipa/libipa/proc_prfle_dwnld.c: https://gerrit.osmocom.org/c/onomondo-ipa/+/43302/comment/69f1e512_e0f73047?usp=email : PS1, Line 53: * result as a whole to the eIM. In case of failure it is the responsibility of the eIM to look at error Now this comment is wrong, I would rephrase it like this: In case the ES10b PrepareDownload returns a PrepareDownloadResponseError, the procedure is stopped. In all other cases we will forward the unmodified result to the eIM to continue the procedure normally. (see also: GSMA SGP.32, section 3.2.3.2, step 16) -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43302?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: I6f13a12c494be57d6a6f377567bf38b0235ec4aa Gerrit-Change-Number: 43302 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: dexter <[email protected]> Gerrit-Attention: jolly <[email protected]> Gerrit-Comment-Date: Wed, 19 Aug 2026 14:42:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
