Attention is currently required from: dexter, lynxis lazus.

neels has posted comments on this change by neels. ( 
https://gerrit.osmocom.org/c/pysim/+/42829?usp=email )

Change subject: saip.PES.rebuild_mandatory_services(): set 5G get-identity, 
profile-a-x25519, profile-b-p256
......................................................................


Patch Set 5: Code-Review+2

(1 comment)

File pySim/esim/saip/__init__.py:

https://gerrit.osmocom.org/c/pysim/+/42829/comment/b9da896b_b7ce5e60?usp=email :
PS5, Line 1739:         # - Iff the SUCI-CalcInfo for USIM (DF.SAIP) contains a 
key of profile-A ("identifier": 1),
> typo in Iff
it's not a typo: iff == if and only if
https://en.wikipedia.org/wiki/iff



--
To view, visit https://gerrit.osmocom.org/c/pysim/+/42829?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ibc29c6437c5c92e2b14938b733156536863465c1
Gerrit-Change-Number: 42829
Gerrit-PatchSet: 5
Gerrit-Owner: neels <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: lynxis lazus <[email protected]>
Gerrit-Reviewer: neels <[email protected]>
Gerrit-Attention: lynxis lazus <[email protected]>
Gerrit-Attention: dexter <[email protected]>
Gerrit-Comment-Date: Tue, 18 Aug 2026 23:56:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: lynxis lazus <[email protected]>

Reply via email to