Attention is currently required from: lynxis lazus. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-iuh/+/43258?usp=email )
Change subject: ranap: Introduce new APIs to encode rab_ass for gtp and rtp ...................................................................... Patch Set 1: (3 comments) File include/osmocom/ranap/ranap_msg_factory.h: https://gerrit.osmocom.org/c/osmo-iuh/+/43258/comment/174d22e8_6748b511?usp=email : PS1, Line 47: struct msgb *ranap_new_msg_rab_assign_voice2(uint8_t rab_id, const struct osmo_sockaddr *rtp_addr, > the indention of the args looks weird, but fine. Done https://gerrit.osmocom.org/c/osmo-iuh/+/43258/comment/c1370eed_0e7f576d?usp=email : PS1, Line 56: uint32_t gtp_tei, > the indention of the args looks weird, but fine. Done File src/ranap_msg_factory.c: https://gerrit.osmocom.org/c/osmo-iuh/+/43258/comment/af9ca08c_0e732f72?usp=email : PS1, Line 975: .sin_port = htons(2152), > You set a port here, which the old code doesn't. […] I know it's not necessary, it doesn't harm either though. I can leave it as a 0. -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/43258?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I3a8800afd03b94349c8acec778ab7003819e80af Gerrit-Change-Number: 43258 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: lynxis lazus <[email protected]> Gerrit-Attention: lynxis lazus <[email protected]> Gerrit-Comment-Date: Tue, 18 Aug 2026 09:46:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: lynxis lazus <[email protected]>
