Attention is currently required from: Hoernchen, laforge. dexter has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/43254?usp=email )
Change subject: ts_102_221: support EF.ARR record decoding for DF, not just EF ...................................................................... Patch Set 1: Code-Review+1 (4 comments) Patchset: PS1: I have tried it out. It works fine. Except that I now also get a non working --decode-for-df flag on the regular read_record(s)_decoded commands. File pySim/ts_102_221.py: https://gerrit.osmocom.org/c/pysim/+/43254/comment/ace3729f_b226bf3e?usp=email : PS1, Line 755: arr_seq = self.__get_do_sequence(kwargs.get('encode_for_df', False)) I assume this is to maintain API consistency and possibly a future "update_arr_record" command. https://gerrit.osmocom.org/c/pysim/+/43254/comment/421c5714_6bea3f9f?usp=email : PS1, Line 760: read_arr_argparser = copy.copy(LinFixedEF.ShellCommands.read_rec_dec_parser) When I try this out and do a "read_record_decoded --help", I also get the --decode-for-df parameter in the helpscreen. I think you have to use copy.deepcopy here. (This patch only adds the encode/decode variants to the read_arr_record(s) commands. Maye the feature would also be useful with the regular read_record_decoded commands as well?) https://gerrit.osmocom.org/c/pysim/+/43254/comment/ae06672f_57beaa6b?usp=email : PS1, Line 761: read_arr_argparser.add_argument('--decode-for-df', action='store_true') Maybe adding a help text like: help='decode EF.ARR record for DF' ? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43254?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I05e629e8b7dc705730d7039d2d0170ee24f8f844 Gerrit-Change-Number: 43254 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <[email protected]> Gerrit-Reviewer: Hoernchen <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-Attention: Hoernchen <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Comment-Date: Mon, 17 Aug 2026 11:07:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
