Attention is currently required from: dexter, jolly.

laforge has posted comments on this change by jolly. ( 
https://gerrit.osmocom.org/c/onomondo-ipa/+/43202?usp=email )

Change subject: Introduce 'operation' parameters to main file
......................................................................


Patch Set 3: Code-Review+1

(2 comments)

File src/ipa/main.c:

https://gerrit.osmocom.org/c/onomondo-ipa/+/43202/comment/bb47e4e0_6888077c?usp=email
 :
PS2, Line 50: printf(" -o get-eim-package     ..... Ask eIM for eIM package and 
process it (default operation)\n");
            :   printf(" -o add-initial-eim PATH..... set initial eIM 
configuration from given file\n");
            :   printf(" -o euicc-memory-reset....... reset eUICC memory\n");
> to make it more clear, those should be gruoped somewhere at the beginning or 
> the end of the help mes […]
Done


https://gerrit.osmocom.org/c/onomondo-ipa/+/43202/comment/5e74a8c7_3a5c7c83?usp=email
 :
PS2, Line 193:                                  break;
> I think this change is only half-done. […]
Done



--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43202?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I6b960f840820990de40fb07332669ddbfcdf1e7d
Gerrit-Change-Number: 43202
Gerrit-PatchSet: 3
Gerrit-Owner: jolly <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Attention: jolly <[email protected]>
Gerrit-Attention: dexter <[email protected]>
Gerrit-Comment-Date: Thu, 13 Aug 2026 11:13:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge <[email protected]>

Reply via email to