Attention is currently required from: dexter, jolly.

laforge has posted comments on this change by jolly. ( 
https://gerrit.osmocom.org/c/onomondo-ipa/+/43202?usp=email )

Change subject: Introduce 'operation' option to main file
......................................................................


Patch Set 2:

(1 comment)

File src/ipa/main.c:

https://gerrit.osmocom.org/c/onomondo-ipa/+/43202/comment/2ec3aced_884d10dd?usp=email
 :
PS2, Line 50: printf(" -o get-eim-package     ..... Ask eIM for eIM package and 
process it (default operation)\n");
            :   printf(" -o add-initial-eim PATH..... set initial eIM 
configuration from given file\n");
            :   printf(" -o euicc-memory-reset....... reset eUICC memory\n");
to make it more clear, those should be gruoped somewhere at the beginning or 
the end of the help message. Just think of how python argparse would sort 
something like this (see pysim-shell etc for examples).

We might also have the operation as a positional argument without the '-o' 
after all the actual options.  So a bit more like e.g. es90_client.py or 
es2p_client.py



--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43202?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I6b960f840820990de40fb07332669ddbfcdf1e7d
Gerrit-Change-Number: 43202
Gerrit-PatchSet: 2
Gerrit-Owner: jolly <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Attention: jolly <[email protected]>
Gerrit-Attention: dexter <[email protected]>
Gerrit-Comment-Date: Wed, 12 Aug 2026 08:37:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

Reply via email to