Attention is currently required from: jolly, pespin. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43144?usp=email )
Change subject: library/euicc: add ESipa JSON encoder/decoder module ...................................................................... Patch Set 5: (1 comment) File eim/eIM_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43144/comment/7b6f7079_979ce0cb?usp=email : PS4, Line 441: esipa_res := dec_EsipaMessageFromEimToIpa(response_http.response_binary.body); > Isn't it enough o move the "if (mp_esipa_json == true)" here? […] Thanks for your input. My first thought was to separate the ASN.1 and JSON code paths, but this creates a lot of code-dup in the receive functions. I have reworked this now. The send functions are different enough so I think we can keep those as they are. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43144?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8b6a87f39ca23658d980d19cf257b8994ea1cecb Gerrit-Change-Number: 43144 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Attention: jolly <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Tue, 11 Aug 2026 07:37:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]>
