lynxis lazus has submitted this change. (
https://gerrit.osmocom.org/c/simtrace2/+/43133?usp=email )
(
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted
one.
)Change subject: host: simtrace2_api: do not log random memory
......................................................................
host: simtrace2_api: do not log random memory
tx_cfg->features is logged before the memcpy() that fills it.
Looks like no one is using config.ac --enable-sanitize?
Change-Id: Id8369d312c8600ba9eea80c8f7782f196d7e20d1
---
M host/lib/simtrace2_api.c
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
lynxis lazus: Looks good to me, approved
Jenkins Builder: Verified
laforge: Looks good to me, but someone else must approve
diff --git a/host/lib/simtrace2_api.c b/host/lib/simtrace2_api.c
index 37be08a..e2bad31 100644
--- a/host/lib/simtrace2_api.c
+++ b/host/lib/simtrace2_api.c
@@ -280,7 +280,7 @@
tx_cfg = (struct cardemu_usb_msg_config *) msgb_put(msg,
sizeof(*tx_cfg));
- LOGSLOT(ci->slot, LOGL_NOTICE, "<= %s(features=%08x)\n", __func__,
tx_cfg->features);
+ LOGSLOT(ci->slot, LOGL_NOTICE, "<= %s(features=%08x)\n", __func__,
user_cfg->features);
memcpy(tx_cfg, user_cfg, sizeof(*tx_cfg));
osmo_store32le(user_cfg->features, &tx_cfg->features);
--
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/43133?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: Id8369d312c8600ba9eea80c8f7782f196d7e20d1
Gerrit-Change-Number: 43133
Gerrit-PatchSet: 3
Gerrit-Owner: Hoernchen <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: lynxis lazus <[email protected]>
