Attention is currently required from: fixeria.

pespin has posted comments on this change by fixeria. ( 
https://gerrit.osmocom.org/c/libosmocore/+/43190?usp=email )

Change subject: gsm29205: fix out-of-bounds read in osmo_dec_gcr()
......................................................................


Patch Set 1:

(1 comment)

File tests/gsm29205/gsm29205_test.c:

https://gerrit.osmocom.org/c/libosmocore/+/43190/comment/685c94b8_e8dadf75?usp=email
 :
PS1, Line 121:          printf("\tlen=%u: rc=%d\n", len, rc);
better avoid printing the errno int value, since it can change on different 
platforms/architecures, we already run into this in the past.

Se how for instance test above prints "OK" vs "FAIL". You can also match 
against an errno define and print its string name.



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/43190?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I6855d6c810c2b4274ccfd7bc861405f9b4e09343
Gerrit-Change-Number: 43190
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Mon, 10 Aug 2026 08:10:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

Reply via email to