Attention is currently required from: jolly, laforge. dexter has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43043?usp=email )
Change subject: V1.2: Add function ES10b.EnableEmergencyProfile ...................................................................... Patch Set 3: Code-Review+1 (3 comments) File include/onomondo/ipa/ipad.h: https://gerrit.osmocom.org/c/onomondo-ipa/+/43043/comment/cccb1cba_04d54c4b?usp=email : PS3, Line 99: int ipa_enable_emergency_profile(struct ipa_context *ctx); you can shorten "profile" to "prfle", we used this abbreviation in lots of other places too. File src/ipa/libipa/es10b_en_emerg_prfle.h: https://gerrit.osmocom.org/c/onomondo-ipa/+/43043/comment/db204658_4793ada0?usp=email : PS3, Line 14: struct EnableEmergencyProfileResponse *res; Also here, it is just an integer that is returned, maybe return it directly to get an API that is simpler to use? File src/ipa/main.c: https://gerrit.osmocom.org/c/onomondo-ipa/+/43043/comment/39d88b30_0e485d3f?usp=email : PS3, Line 179: { "enable-emergency-profile", no_argument, NULL, OPT_ENABLEEMGERGENCY}, See comment from @[email protected] in the previous patch. I think we should clean this up. -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43043?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: I0304b869a14a36b82cc2d1676b2a5f613e1da171 Gerrit-Change-Number: 43043 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-Attention: jolly <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Comment-Date: Fri, 07 Aug 2026 15:51:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
