Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/simtrace2/+/43185?usp=email )
Change subject: Add osmo_apdu_segment_in2() to ensure correct parsing of GP GET DATA ...................................................................... Patch Set 1: (6 comments) File host/lib/apdu_dispatch.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/simtrace2/+/43185/comment/8c7325b1_b0456667?usp=email : PS1, Line 85: * \param ac APDU context accross successive calls 'accross' may be misspelled - perhaps 'across'? Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/simtrace2/+/43185/comment/0c317887_489f4c74?usp=email : PS1, Line 86: * \param prev_ac Previous APDU context accross successive calls 'accross' may be misspelled - perhaps 'across'? File host/tests/apdu_dispatch/apdu_dispatch_test.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/simtrace2/+/43185/comment/49267986_6a499543?usp=email : PS1, Line 78: printf("All tests passed.\n"); code indent should use tabs where possible Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/simtrace2/+/43185/comment/0ca5dbd8_4fb38929?usp=email : PS1, Line 78: printf("All tests passed.\n"); please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/simtrace2/+/43185/comment/e1a345ac_92187a79?usp=email : PS1, Line 79: return 0; code indent should use tabs where possible Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/simtrace2/+/43185/comment/ec23c3c0_a00422c3?usp=email : PS1, Line 79: return 0; please, no spaces at the start of a line -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/43185?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Ie238662e7e6a10dd4283ede0c8d8d73bc375c247 Gerrit-Change-Number: 43185 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <[email protected]> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Fri, 07 Aug 2026 13:59:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
