Attention is currently required from: pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43116?usp=email )
Change subject: Transceiver52M: implement TRXDv2 support ...................................................................... Patch Set 5: (1 comment) File Transceiver52M/Transceiver.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/43116/comment/4b6ac3e6_052181e9?usp=email : PS1, Line 1200: } while (br.flags & OSMO_TRXD_F_BATCH_IND); > I wonder whether we can end in a infinite loop here with req_parse returning > eg. rc=0 above. I've modified the check above to return early on `rc <= 0`. So if for whatever reason `osmo_trxd_burst_req_parse()` returns 0 (e.g. somebody changes it some day), we're safe. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43116?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ie6a33e3980b3ca4ab05a3d4221d5a8ba0132233d Gerrit-Change-Number: 43116 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Tue, 04 Aug 2026 17:50:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]>
