Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43163?usp=email )
Change subject: sccp2sua: fix buffer overrun in osmo_isup_party_parse() ...................................................................... Patch Set 1: (1 comment) File src/sccp2sua.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/43163/comment/135e4dcb_8f8360cf?usp=email : PS1, Line 74: if (in_num_bytes * 2 >= out_digits_size) shouldn't you account for one extra byte in this check in the case it's even number of bytes? because then you need one extra digit anyway. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43163?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Iccfbcf22a719544399c7a524b293de9e1a040cf8 Gerrit-Change-Number: 43163 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Tue, 04 Aug 2026 14:13:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
