Attention is currently required from: pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43108?usp=email )
Change subject: libosmo-trx/client: add TRXC client (command queue) API ...................................................................... Patch Set 3: (3 comments) File libosmo-trx/include/osmocom/trx/trxc_client.h: https://gerrit.osmocom.org/c/osmo-trx/+/43108/comment/5b2e27b3_339276b2?usp=email : PS1, Line 32: struct osmo_trxc_client_ops { > I'd rather add APIs to set each callbacks and private pointers, as done in > osmo_stream, to allow for […] Acknowledged File libosmo-trx/src/trxc_client.c: https://gerrit.osmocom.org/c/osmo-trx/+/43108/comment/2f361e90_f7e479c1?usp=email : PS1, Line 190: void osmo_trxc_client_set_retrans(struct osmo_trxc_client *client, unsigned int sec) > set_restrans_timeout?Is 0 allowed? document it and if not allowed return an > error. Done https://gerrit.osmocom.org/c/osmo-trx/+/43108/comment/0918f3a6_ebfa27aa?usp=email : PS1, Line 481: client->setformat_ver_req = ver_max; > I'd rather store the user cb + cb_data in a struct, pass it to > osmo_trxc_client_send_cmd() below ins […] Good idea, done. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43108?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I817e394f74a10e3adae4a0b58342c82acdf0794e Gerrit-Change-Number: 43108 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Mon, 03 Aug 2026 21:53:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]>
