Attention is currently required from: pespin.

fixeria has posted comments on this change by fixeria. ( 
https://gerrit.osmocom.org/c/osmo-trx/+/43115?usp=email )

Change subject: Transceiver52M: migrate to libosmo-trx
......................................................................


Patch Set 3:

(2 comments)

File Transceiver52M/Transceiver.cpp:

https://gerrit.osmocom.org/c/osmo-trx/+/43115/comment/ee2d1029_7f2ef91c?usp=email
 :
PS1, Line 660: /* Convert a soft bit normalized to 0..1 (1.0 = confident '1') 
into the
> `float_soft_bit_to_sbit()` isn't new - it's the same quantization step the 
> old code always did; move […]
Done


https://gerrit.osmocom.org/c/osmo-trx/+/43115/comment/2df522ec_17365912?usp=email
 :
PS1, Line 801:   bi->toa256 = (int16_t) lround(ebp.toa * 256.0);
> The reason is that libosmo-trx's `struct osmo_trxd_burst_ind` is different 
> from the old `struct trx_ […]
Done



--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43115?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I458ec85c56e2101d073c8c35f11c147191c4ea0c
Gerrit-Change-Number: 43115
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Mon, 03 Aug 2026 21:48:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <[email protected]>
Comment-In-Reply-To: pespin <[email protected]>

Reply via email to