Attention is currently required from: lynxis lazus.

laforge has posted comments on this change by lynxis lazus. ( 
https://gerrit.osmocom.org/c/simtrace2/+/43003?usp=email )

Change subject: firmware: Drop CEMU_TX_DATA when sim is in-active
......................................................................


Patch Set 5:

(1 comment)

File firmware/libcommon/source/card_emu.c:

https://gerrit.osmocom.org/c/simtrace2/+/43003/comment/66243dcc_81538ecc?usp=email
 :
PS5, Line 218: /* if the card should enque messages */
wording is slightly sub-optimal: A card itself (like an actual SIM) doesn't 
queue messages, right?  Also, what kind of messages? TPDU from the reader? No, 
this is about ST2 USB protocol messages controlling thee emulator?  Let's 
please make this more clear.



--
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/43003?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: I796e548225a742cddfde12bd6a60e4d2e5c04c8f
Gerrit-Change-Number: 43003
Gerrit-PatchSet: 5
Gerrit-Owner: lynxis lazus <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: lynxis lazus <[email protected]>
Gerrit-Comment-Date: Sat, 01 Aug 2026 09:16:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

Reply via email to