Attention is currently required from: dexter.

jolly has posted comments on this change by jolly. ( 
https://gerrit.osmocom.org/c/onomondo-ipa/+/43047?usp=email )

Change subject: V1.2: Add TERMINAL CAPABILITY for IoT support
......................................................................


Patch Set 2:

(3 comments)

File src/ipa/libipa/euicc.c:

https://gerrit.osmocom.org/c/onomondo-ipa/+/43047/comment/2e81eb1f_2ed1fa42?usp=email
 :
PS1, Line 360: /* Send terminal capablilities, see also 3gpp TS 102.221 
V16.2.0, section 11.1.19.2.4 */
> I would change the section to 11.1. […]
Done


https://gerrit.osmocom.org/c/onomondo-ipa/+/43047/comment/e3a83f6c_f78e1c7b?usp=email
 :
PS1, Line 534: {
> I think we should add a spec reference here: […]
Done


https://gerrit.osmocom.org/c/onomondo-ipa/+/43047/comment/9f439c41_dc9ecefa?usp=email
 :
PS1, Line 545:  if (!ctx->cfg->iot_euicc_emu_enabled) {
> I think we should pack termcap_euicc and termcap_iot into one TLV object and 
> send it with a single T […]
Done



--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43047?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I1116bee93b31ee4a159125d840d7c5866be6fdb4
Gerrit-Change-Number: 43047
Gerrit-PatchSet: 2
Gerrit-Owner: jolly <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <[email protected]>
Gerrit-Attention: dexter <[email protected]>
Gerrit-Comment-Date: Thu, 30 Jul 2026 12:24:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: dexter <[email protected]>

Reply via email to