Attention is currently required from: laforge, pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/simtrace2/+/43004?usp=email )
Change subject: firmware: Add talloc_report_buf() encode the allocation by bits ...................................................................... Patch Set 6: (2 comments) File firmware/libcommon/source/pseudo_talloc.c: https://gerrit.osmocom.org/c/simtrace2/+/43004/comment/94c32fb7_096c3084?usp=email : PS6, Line 85: msgb_inuse_too_ig > spelling? too_ig -> too_big ? Done https://gerrit.osmocom.org/c/simtrace2/+/43004/comment/405dd4a4_83c83bda?usp=email : PS6, Line 101: return bitoff + 1; > are you sure the +1 in here is correct? +1 is always correct. if bitpos == 7 we might waste a byte. -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/43004?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I3a8ddbe4100f342db2c59ad1fb9aa0014efc62b8 Gerrit-Change-Number: 43004 Gerrit-PatchSet: 6 Gerrit-Owner: lynxis lazus <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Thu, 30 Jul 2026 12:09:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]> Comment-In-Reply-To: pespin <[email protected]>
