Attention is currently required from: Hoernchen, laforge. lynxis lazus has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/simtrace2/+/43125?usp=email )
Change subject: firmware: use the full 11 bit US_FIDI.FI_DI_RATIO ...................................................................... Patch Set 1: Code-Review+1 (3 comments) File firmware/libcommon/source/mode_cardemu.c: https://gerrit.osmocom.org/c/simtrace2/+/43125/comment/f9e5fa91_96394964?usp=email : PS1, Line 390: usart->US_FIDI = fidi & US_FIDI_FI_DI_RATIO_Msk; I would rather use US_FIDI_FI_DI_RATIO(fidi) here. It is correct, but only works because the bit position of US_FIDI_FI_DI_RATIO is 0. File firmware/libcommon/source/simtrace_iso7816.c: https://gerrit.osmocom.org/c/simtrace2/+/43125/comment/9e8ce168_cf7e9b19?usp=email : PS1, Line 130: if (ratio > 0 && ratio <= US_FIDI_FI_DI_RATIO_Msk) { It is correct, but because this is a define from ./libchip_sam3s/include/SAM3S.h I would have used a protocol define with 0x7fffu. https://gerrit.osmocom.org/c/simtrace2/+/43125/comment/ca9dcbb5_194a75bd?usp=email : PS1, Line 137: usart->base->US_FIDI = (ratio & US_FIDI_FI_DI_RATIO_Msk); see previous usage of US_FIDI_FI_DI_RATIO(fidi) -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/43125?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I6211dd5be7c5c5d2150af2aa37a403b33e6d340d Gerrit-Change-Number: 43125 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: lynxis lazus <[email protected]> Gerrit-Attention: Hoernchen <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Comment-Date: Thu, 30 Jul 2026 11:16:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
