Attention is currently required from: pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43106?usp=email )
Change subject: libosmo-trx/trxc: enlarge the params buffer ...................................................................... Patch Set 2: (1 comment) File libosmo-trx/include/osmocom/trx/trxc.h: https://gerrit.osmocom.org/c/osmo-trx/+/43106/comment/e6022c14_cff9a27a?usp=email : PS1, Line 16: #define OSMO_TRXC_PARAMS_LEN_MAX (OSMO_TRXC_MSG_BUF_SIZE - OSMO_TRXC_CMD_LEN_MAX - 32) > The -32 here is to account for whitespace? Yes. It's actually 18 characters: `RSP ` (4) + a space before `<status>` + `<status>` itself (up to 11 chars) + a space before `<params>` + the terminating `\0`. But I rounded it up to 32, just to be sure. I've updated the comment clarifying this. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43106?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I2f65b213f5ada499eea4abae87d3727057e03e22 Gerrit-Change-Number: 43106 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Wed, 29 Jul 2026 12:57:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]>
