Attention is currently required from: lynxis lazus. Hoernchen has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/simtrace2/+/43129?usp=email )
Change subject: firmware: sniffer: fix ~INS procedure byte comparison ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Nice catch. […] We should not have more, which -Werror=sign-compare would ensure.. The problem is that this mostly spams "annoying" warnings due to loop variables and gets ignored by everyone because these kind of comparison bugs are much more fun than fixing warnings. -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/43129?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I800f50ef35356429d07aa685ea919e70ec34946e Gerrit-Change-Number: 43129 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: lynxis lazus <[email protected]> Gerrit-Attention: lynxis lazus <[email protected]> Gerrit-Comment-Date: Wed, 29 Jul 2026 11:22:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: lynxis lazus <[email protected]>
