Attention is currently required from: dexter, jolly. Jenkins Builder has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43032?usp=email )
Change subject: V1.2: Add new fields to ProfileInfo list ...................................................................... Patch Set 2: (3 comments) File src/ipa/libipa/es10c_get_prfle_info.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-ipa/+/43032/comment/32017f7c_55462c10?usp=email : PS2, Line 78: if (conv_req && conv_req->fallback_attribute_removed) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-ipa/+/43032/comment/9e0b7dba_050ff48b?usp=email : PS2, Line 109: struct ipa_es10c_get_prfle_info_req *conv_get_prfle_info_req(const struct ipa_es10c_get_prfle_info_req *req) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-ipa/+/43032/comment/ccfe0cce_58bee6c2?usp=email : PS2, Line 110: uint8_t default_tags[] = { 0x5A, 0x4F, 0x9F, 0x70, 0x91, 0x92, 0x95, 0x9F,0x7B, 0x9F,0x26, 0x9F,0x67 }; space required after that ',' (ctx:VxV) -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43032?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: I6667dba8dd84817cfee69daa1c44b98239fa171c Gerrit-Change-Number: 43032 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-Attention: jolly <[email protected]> Gerrit-Attention: dexter <[email protected]> Gerrit-Comment-Date: Tue, 28 Jul 2026 09:59:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
