Attention is currently required from: daniel.

pespin has posted comments on this change by daniel. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42935?usp=email )

Change subject: stp: add ASP_SCCP_N_NOTICE_req support and f_asp_tx_notice()
......................................................................


Patch Set 2:

(1 comment)

File stp/STP_Tests_TCAP.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42935/comment/e6081a6a_a1b5631f?usp=email
 :
PS2, Line 222: private function f_asp_tx_notice(template (value) 
SCCP_PAR_UserData userData,
I don't see this function ever being used here nor in current master. What am I 
missing? why was this added? It needs to be dropped in a new commit.



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42935?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I74c05405f1c99d43b4bf863f959275ee51301f2e
Gerrit-Change-Number: 42935
Gerrit-PatchSet: 2
Gerrit-Owner: daniel <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <[email protected]>
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: daniel <[email protected]>
Gerrit-Comment-Date: Mon, 27 Jul 2026 15:34:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

Reply via email to