Attention is currently required from: jolly, osmith. dexter has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42967?usp=email )
Change subject: IPAd: Make tests work with testenv and current master of IPAd ...................................................................... Patch Set 4: Code-Review-1 (1 comment) Patchset: PS4: I think it is dangerous to have the nvstate.bin in this patch. We should generate the nvstate.bin dynamically using a script before the test runs. The problem is that when we make changes to some of the structs that make up the nvstate.bin file, we may end up with errors which may be difficult to find. In the best case, the IPAd will reject de-serializing the nvstate in the worst case (if we have not increased the version) there might be unexpected behavior. Let's add a mechanism that generates the nvstate.bin before each testrun. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42967?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id4abf15feb179b17594bd11c6e7089469684900c Gerrit-Change-Number: 42967 Gerrit-PatchSet: 4 Gerrit-Owner: jolly <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Attention: osmith <[email protected]> Gerrit-Attention: jolly <[email protected]> Gerrit-Comment-Date: Thu, 23 Jul 2026 12:45:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
