Attention is currently required from: jolly. dexter has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43030?usp=email )
Change subject: V1.2: EuiccResultData.setFallbackAttribute / unsetFallbackAttribute ...................................................................... Patch Set 1: (2 comments) File src/ipa/libipa/es10b_load_euicc_pkg.c: https://gerrit.osmocom.org/c/onomondo-ipa/+/43030/comment/dec39095_131ae2fd?usp=email : PS1, Line 278: I would suggest not to pretend that the setFallbackAttribute command was successful. It is probably better to fail in this case. Otherwise the REST API user of the eIM may end up with false information. SGP.32 section 4.3.7 says: If the eUICC does not support the Fallback Mechanism the procedure SHALL stop and the result of this command SHALL indicate error (‘processingTerminated’ with ‘unknownOrDamagedCommand). >From that I deduct that the fallback mechanism is not a must-have for an >SGP.32 V.1.2 compliant eUICC. I would say that you can just put SetFallbackAttributeResult_undefinedError into the SetFallbackAttributeResult instead of hard failing the overall procedure, even though this is not 100% what is specified. We are not 100% spec compliant here either, so I think this is a good compromise. https://gerrit.osmocom.org/c/onomondo-ipa/+/43030/comment/4891d719_29f57b34?usp=email : PS1, Line 291: (see comment above) Here I would use: UnsetFallbackAttributeResult_undefinedError -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43030?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: I59fba32cb12de22f71b3238adcbab5fc7f66e991 Gerrit-Change-Number: 43030 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: dexter <[email protected]> Gerrit-Attention: jolly <[email protected]> Gerrit-Comment-Date: Wed, 22 Jul 2026 09:26:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
