Attention is currently required from: jolly. dexter has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43025?usp=email )
Change subject: V1.2: Update from "EnableUsingDD" to "ImmediateEnable" function ...................................................................... Patch Set 1: -Code-Review (1 comment) File src/ipa/libipa/proc_prfle_inst.c: https://gerrit.osmocom.org/c/onomondo-ipa/+/43025/comment/abf43a87_a0403900?usp=email : PS1, Line 45: ipa_es10b_immediate_enable(ctx); (this refers to WIP: Add refreshFlag, read the review comments there first) Here you would pass the refreshFlag together with the (aforementioned) req struct. Use the configured refreshFlag from ctx->cfg->refresh_flag. (please do not greb the refresh_flag from inside ipa_es10b_immediate_enable, I guess the architecture is a bit unclean here. However, since the refreshFlag is a an input parameter of the ES10b function call, it must be passed through a req parameter.) (It is also a bit vague what exactly grants the immediate profile enable, I guess when the immediateEnableFlag is not set inside the eUICC, immediateEnable is not granted.) -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43025?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: Id750b2f5ca6c08a013aa30f876aa37e6291a30d5 Gerrit-Change-Number: 43025 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-Attention: jolly <[email protected]> Gerrit-Comment-Date: Tue, 21 Jul 2026 16:15:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
