Jenkins Builder has posted comments on this change by dexter. ( 
https://gerrit.osmocom.org/c/pysim/+/42996?usp=email )

Change subject: Remote Card Procedure Framework
......................................................................


Patch Set 1:

(20 comments)

File contrib/rcp/rcp_utils.py:

Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/pysim/+/42996/comment/f1770402_e98292e4?usp=email :
PS1, Line 167:         """Set crash_report_flag. Thie method shall be called if 
an unrecoverable error has occured."""
'occured' may be misspelled - perhaps 'occurred'?


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/pysim/+/42996/comment/cf96e49c_89f58f4f?usp=email :
PS1, Line 173:         inculde communications (records_comm) and debug 
information (records_debug). Otherwise only the metadata
'inculde' may be misspelled - perhaps 'include'?


File contrib/rcp/usage_example/certs/example_ssl_rcpc_rcps_cert.pem:

Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/pysim/+/42996/comment/abde13dd_af1050da?usp=email :
PS1, Line 36:             X509v3 Basic Constraints:
trailing whitespace


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/pysim/+/42996/comment/b8e11ee1_1118ac34?usp=email :
PS1, Line 38:             X509v3 Subject Key Identifier:
trailing whitespace


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/pysim/+/42996/comment/ac1a6f50_6bf36588?usp=email :
PS1, Line 40:             X509v3 Authority Key Identifier:
trailing whitespace


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/pysim/+/42996/comment/f1ab9250_d8eb41e0?usp=email :
PS1, Line 44:             X509v3 Extended Key Usage:
trailing whitespace


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/pysim/+/42996/comment/aea29ca8_da6eeee3?usp=email :
PS1, Line 46:             X509v3 Key Usage:
trailing whitespace


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/pysim/+/42996/comment/c54da26c_0addf1ec?usp=email :
PS1, Line 48:             X509v3 Subject Alternative Name:
trailing whitespace


File contrib/rcp/usage_example/certs/example_ssl_rcpm_rcps_cert.pem:

Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/pysim/+/42996/comment/d925fb60_8ee35059?usp=email :
PS1, Line 36:             X509v3 Basic Constraints:
trailing whitespace


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/pysim/+/42996/comment/5a489926_bbdfac14?usp=email :
PS1, Line 38:             X509v3 Subject Key Identifier:
trailing whitespace


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/pysim/+/42996/comment/1d67ef39_b457779a?usp=email :
PS1, Line 40:             X509v3 Authority Key Identifier:
trailing whitespace


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/pysim/+/42996/comment/e6e08ab2_f1cdcd5b?usp=email :
PS1, Line 44:             X509v3 Extended Key Usage:
trailing whitespace


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/pysim/+/42996/comment/1bb6da9c_4d1a9c97?usp=email :
PS1, Line 46:             X509v3 Key Usage:
trailing whitespace


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/pysim/+/42996/comment/5ab1dbce_333b4ffd?usp=email :
PS1, Line 48:             X509v3 Subject Alternative Name:
trailing whitespace


File contrib/rcp/usage_example/certs/example_ssl_rcps_rcpm_cert.pem:

Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/pysim/+/42996/comment/b4ba4609_ad389568?usp=email :
PS1, Line 36:             X509v3 Basic Constraints:
trailing whitespace


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/pysim/+/42996/comment/bf9ddb2b_618819d8?usp=email :
PS1, Line 38:             X509v3 Subject Key Identifier:
trailing whitespace


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/pysim/+/42996/comment/3e78ee58_bafdfe0a?usp=email :
PS1, Line 40:             X509v3 Authority Key Identifier:
trailing whitespace


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/pysim/+/42996/comment/f6d20d6f_6b64efed?usp=email :
PS1, Line 44:             X509v3 Extended Key Usage:
trailing whitespace


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/pysim/+/42996/comment/d83eed4b_2a476f54?usp=email :
PS1, Line 46:             X509v3 Key Usage:
trailing whitespace


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/pysim/+/42996/comment/67609067_645b6211?usp=email :
PS1, Line 48:             X509v3 Subject Alternative Name:
trailing whitespace



--
To view, visit https://gerrit.osmocom.org/c/pysim/+/42996?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I8500a98492328ed5b3eb4bb177af2a4a8e481f80
Gerrit-Change-Number: 42996
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <[email protected]>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Mon, 13 Jul 2026 13:04:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

Reply via email to