Attention is currently required from: fixeria.

osmith has posted comments on this change by fixeria. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42915?usp=email )

Change subject: library: add f_gsm_fn_{sum,sub,diff}()
......................................................................


Patch Set 2:

(1 comment)

File library/GSM_Types.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42915/comment/8ca8291f_8989b6e3?usp=email
 :
PS2, Line 450: function f_gsm_fn_diff(GsmFrameNumber a, GsmFrameNumber b) 
return GsmFrameNumber {
f_gsm_fn_diff is unused, even in 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42916/2. would it maybe make 
more sense to only introduce it later when it actually gets used?



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42915?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie91ccef5d3f170f4a341a6cf9d3323a896b299e6
Gerrit-Change-Number: 42915
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Thu, 02 Jul 2026 13:31:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

Reply via email to