laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/42905?usp=email )
Change subject: lint: ignore LINUX_VERSION_CODE ...................................................................... lint: ignore LINUX_VERSION_CODE When running the linter against dahdi-linux.git or potentially other repositories with out-of-tree linux kernel modules, it should not complain about the LINUX_VERSION_CODE being used there: > drivers/dahdi/dahdi-base.c:6397: WARNING:LINUX_VERSION_CODE: > LINUX_VERSION_CODE should be avoided, code should be for the version to > which it is merged Change-Id: I82d64d43c04561b1643785cb71cfee92e513e560 --- M lint/checkpatch/checkpatch_osmo.sh 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved daniel: Looks good to me, but someone else must approve diff --git a/lint/checkpatch/checkpatch_osmo.sh b/lint/checkpatch/checkpatch_osmo.sh index 50551b0..ec10b0c 100755 --- a/lint/checkpatch/checkpatch_osmo.sh +++ b/lint/checkpatch/checkpatch_osmo.sh @@ -68,6 +68,7 @@ # * INITIALISED_STATIC: we use this, see also http://lkml.iu.edu/hypermail/linux/kernel/0808.1/2235.html # * LINE_CONTINUATIONS: false positives # * LINE_SPACING: we don't always put a blank line after declarations +# * LINUX_VERSION_CODE: warns about using LINUX_VERSION_CODE, which doesn't make sense outside of the kernel # * LONG_LINE*: should be 120 chars, but exceptions are done often so don't fail here # * MACRO_WITH_FLOW_CONTROL: not followed # * MISSING_SPACE: warns about breaking strings at space characters, not useful for long strings of hex chars @@ -106,6 +107,7 @@ --ignore INITIALISED_STATIC \ --ignore LINE_CONTINUATIONS \ --ignore LINE_SPACING \ + --ignore LINUX_VERSION_CODE \ --ignore LONG_LINE \ --ignore LONG_LINE_COMMENT \ --ignore LONG_LINE_STRING \ -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42905?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I82d64d43c04561b1643785cb71cfee92e513e560 Gerrit-Change-Number: 42905 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <[email protected]> Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]>
