Attention is currently required from: dexter.

fixeria has posted comments on this change by dexter. ( 
https://gerrit.osmocom.org/c/onomondo-eim/+/42876?usp=email )

Change subject: esipa_asn1_handler: fix transactionId handling
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

File src/esipa_asn1_handler_utils.erl:

https://gerrit.osmocom.org/c/onomondo-eim/+/42876/comment/447a62a2_f967a3f5?usp=email
 :
PS1, Line 29:         case maps:is_key(eimTransactionId, Map) of
            :             true ->
            :                 mnesia_db:work_bind(Pid, 
maps:get(eimTransactionId, Map));
            :             _ ->
            :                 ok
            :
Not critical, but you can avoid `maps:get/2` call:

```suggestion
        case maps:find(eimTransactionId, Map) of
            {ok, Value} ->
                mnesia_db:work_bind(Pid, Value);
            _ ->
                ok
        end
```



--
To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42876?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: onomondo-eim
Gerrit-Branch: master
Gerrit-Change-Id: I1340e0c7aed091e8e5a5089ebd6e524512408cf7
Gerrit-Change-Number: 42876
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Attention: dexter <[email protected]>
Gerrit-Comment-Date: Wed, 24 Jun 2026 14:27:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

Reply via email to