Attention is currently required from: dexter, jolly.
Hello Jenkins Builder, jolly,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/onomondo-ipa/+/42872?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: es10b_get_euicc_info: add explanatory comments regarding
EUICCInfo2
......................................................................
es10b_get_euicc_info: add explanatory comments regarding EUICCInfo2
onomondo-ipa has a built-in IoT eUICC emulation. This means that we
have to deal with two different EUICCInfo2 formats, which requires
additional logic in ipa_es10b_get_euicc_info_free to free the
allocated structs correctly. Since it is not immediately obvious
how the logic works, let's add some explanary comments to make it
obvious.
Related: SYS#8101
Change-Id: I282fa91a4099a771a353101b0ce17ae3daae9c42
---
M src/ipa/libipa/es10b_get_euicc_info.c
1 file changed, 14 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/onomondo-ipa refs/changes/72/42872/3
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/42872?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I282fa91a4099a771a353101b0ce17ae3daae9c42
Gerrit-Change-Number: 42872
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: jolly <[email protected]>
Gerrit-Attention: jolly <[email protected]>
Gerrit-Attention: dexter <[email protected]>
