fixeria has submitted this change. ( 
https://gerrit.osmocom.org/c/pysim/+/42267?usp=email )

 (

6 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted 
one.
 )Change subject: saip SmspTpScAddr.get_values_from_pes: allow empty values
......................................................................

saip SmspTpScAddr.get_values_from_pes: allow empty values

Change-Id: Ibbdd08f96160579238b50699091826883f2e9f5a
Jenkins: skip-card-test
---
M pySim/esim/saip/personalization.py
1 file changed, 0 insertions(+), 8 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified




diff --git a/pySim/esim/saip/personalization.py 
b/pySim/esim/saip/personalization.py
index b81da3c..782e8e2 100644
--- a/pySim/esim/saip/personalization.py
+++ b/pySim/esim/saip/personalization.py
@@ -644,19 +644,11 @@
             ef_smsp_dec = ef_smsp.decode_record_bin(f_smsp.body, 1)

             tp_sc_addr = ef_smsp_dec.get('tp_sc_addr', None)
-            if not tp_sc_addr:
-                continue

             digits = tp_sc_addr.get('call_number', None)
-            if not digits:
-                continue

             ton_npi = tp_sc_addr.get('ton_npi', None)
-            if not ton_npi:
-                continue
             international = ton_npi.get('type_of_number', None)
-            if international is None:
-                continue
             international = (international == 'international')

             yield { cls.name: cls.tuple_to_str((international, digits)) }

--
To view, visit https://gerrit.osmocom.org/c/pysim/+/42267?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: merged
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ibbdd08f96160579238b50699091826883f2e9f5a
Gerrit-Change-Number: 42267
Gerrit-PatchSet: 8
Gerrit-Owner: neels <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>

Reply via email to