Attention is currently required from: fixeria, laforge, neels.

dexter has posted comments on this change by fixeria. ( 
https://gerrit.osmocom.org/c/pysim/+/42674?usp=email )

Change subject: SmspTpScAddr: fix SMSP record length and alpha_id padding
......................................................................


Patch Set 7: Code-Review+2

(1 comment)

File pySim/esim/saip/personalization.py:

https://gerrit.osmocom.org/c/pysim/+/42674/comment/354878f2_81013728?usp=email :
PS5, Line 638:             f_smsp.rec_len = 42
> So, all in all, should it be `38` or `42`? […]
I think 42 should work fine as long as f_smsp.rec_len = 42 is set.



--
To view, visit https://gerrit.osmocom.org/c/pysim/+/42674?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ief6e02517f3e96158a2509d763b88aec4bd5a296
Gerrit-Change-Number: 42674
Gerrit-PatchSet: 7
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-CC: neels <[email protected]>
Gerrit-Attention: neels <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Mon, 22 Jun 2026 13:26:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: neels <[email protected]>
Comment-In-Reply-To: fixeria <[email protected]>
Comment-In-Reply-To: dexter <[email protected]>

Reply via email to