Attention is currently required from: Hoernchen, lynxis lazus. jolly has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42781?usp=email )
Change subject: 7816fsm: state_chg before card_uart_tx in tpdu_s_procedure_action ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File ccid_common/iso7816_fsm.c: https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42781/comment/3f2b1452_b641a056?usp=email : PS1, Line 1397: card_uart_set_rx_threshold(ip->uart, 1); > What about here? It is also required to swap the state change with the uart > control? Never mind. This is a card-uart_ctrl (not card_uart_tx). No need to swap things here. -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42781?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Id66f836452674209e25dc3ee4c37d616de30001b Gerrit-Change-Number: 42781 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: lynxis lazus <[email protected]> Gerrit-Attention: Hoernchen <[email protected]> Gerrit-Attention: lynxis lazus <[email protected]> Gerrit-Comment-Date: Tue, 09 Jun 2026 10:25:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: jolly <[email protected]>
