Attention is currently required from: jolly. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42809?usp=email )
Change subject: Add test case to verify proper DSCP settings ...................................................................... Patch Set 9: (1 comment) File tests/testsuite.at: https://gerrit.osmocom.org/c/libosmo-sigtran/+/42809/comment/89561bd9_c5e31db4?usp=email : PS7, Line 32: AT_CHECK([python3 -u $abs_top_builddir/tests/vty/vty_test_runner.py -w $abs_top_builddir -p $abs_srcdir -v TestDSCP],, [ignore], [ignore]) > merging this now as-is, we can always change the way we execute a test after > it has been merged. I think it's fundamentally wrong to merge this as is since now afaiu make check needs osmo-python or whatever to work properly, which may in turn need more stuff in the system to run them, etc. and which in turn will may people run less make check. This is a uuser-facing feature, and hence afaiu should be tested when using the make target like vty or ext-tests or whatever, not tested during unit test phase. So I still think this needs to be changed as mentioned. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42809?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I6ac965998433b4d8213cce30fc3fcf8fe485a092 Gerrit-Change-Number: 42809 Gerrit-PatchSet: 9 Gerrit-Owner: jolly <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: jolly <[email protected]> Gerrit-Comment-Date: Fri, 05 Jun 2026 15:36:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: jolly <[email protected]> Comment-In-Reply-To: laforge <[email protected]> Comment-In-Reply-To: pespin <[email protected]>
