Attention is currently required from: laforge.

Hoernchen has posted comments on this change by Hoernchen. ( 
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42776?usp=email )

Change subject: 7816fsm: Handle unexpected procedure bytes gracefully
......................................................................


Patch Set 1:

(1 comment)

Patchset:

PS1:
> so what do we do about the clang-format linter? If even Patches by the 
> proponent of this are failing […]
I didn't bother formatting it because we never commited the updated rules nor 
the guards around the bespoke code blocks that should not be touched both in 
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42355 , so of course it 
fails. Updating the formatting patches is just re-running clang format and 
updating the 3 commits, while merging it first would likely cause a mess trying 
to get this changeset merged...



--
To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42776?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-Change-Id: Ic53814540775f902fce644a5565a7bd2f177a7fe
Gerrit-Change-Number: 42776
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Comment-Date: Wed, 03 Jun 2026 15:58:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <[email protected]>

Reply via email to