Attention is currently required from: jolly.

pespin has posted comments on this change by jolly. ( 
https://gerrit.osmocom.org/c/libosmo-sigtran/+/42807?usp=email )

Change subject: Add DSCP configuration support for server transport role
......................................................................


Patch Set 3: Code-Review-1

(2 comments)

File src/ss7_xua_srv.c:

https://gerrit.osmocom.org/c/libosmo-sigtran/+/42807/comment/ec32fa29_cc6fda30?usp=email
 :
PS3, Line 408:          osmo_stream_srv_link_set_ip_dscp(xs->server, 
xs->cfg.ip_dscp);
xs->server may actually be NULL, so you need to early return in that case.


File src/ss7_xua_srv_vty.c:

https://gerrit.osmocom.org/c/libosmo-sigtran/+/42807/comment/c71b2d3e_32ccdc52?usp=email
 :
PS3, Line 152:     "ip-dscp " IP_DSCP_RANGE_STR,
As mentioned in IM, this should be "init-ip-dscp".



--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42807?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I35eab3672157c318616f51ee3042243aed263d4e
Gerrit-Change-Number: 42807
Gerrit-PatchSet: 3
Gerrit-Owner: jolly <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: jolly <[email protected]>
Gerrit-Comment-Date: Tue, 02 Jun 2026 15:30:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

Reply via email to