Attention is currently required from: Hoernchen.

laforge has posted comments on this change by Hoernchen. ( 
https://gerrit.osmocom.org/c/simtrace2/+/42749?usp=email )

Change subject: contrib: extend wireshark lua dissector
......................................................................


Patch Set 1:

(1 comment)

File contrib/simtrace.lua:

https://gerrit.osmocom.org/c/simtrace2/+/42749/comment/5a9c0d17_fa92bbf1?usp=email
 :
PS1, Line 612: command
this looks like you are mixing cosmetic changes like removing parenthesis of 
"if" statements with actual logical/funcational code changes.  It is well-known 
that we don't do that but submit those separate of each other.



--
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/42749?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: Ic78824d6122191c7d16152cea643a238c33f49b1
Gerrit-Change-Number: 42749
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <[email protected]>
Gerrit-Attention: Hoernchen <[email protected]>
Gerrit-Comment-Date: Sun, 17 May 2026 17:22:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

Reply via email to