Attention is currently required from: lynxis lazus, pespin.

fixeria has posted comments on this change by lynxis lazus. ( 
https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42745?usp=email )

Change subject: tests: add decode tests for TCAP End tests
......................................................................


Patch Set 2:

(1 comment)

File tests/parse/tcap_parse_test.c:

https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42745/comment/a021946f_5f462598?usp=email
 :
PS2, Line 37: static const unsigned char pkt_end_dialog_w11_w12[] = {0x64, 
0x3c, 0x49, 0x4, 0x7f, 0xc2, 0x92, 0x3a, 0x6b, 0x2a, 0x28, 0x28, 0x6, 0x7, 0x0, 
0x11, 0x86, 0x5, 0x1, 0x1, 0x1, 0xa0, 0x1d, 0x61, 0x1b, 0x80, 0x2, 0x7, 0x80, 
0xa1, 0x9, 0x6, 0x7, 0x4, 0x0, 0x0, 0x1, 0x0, 0xe, 0x3, 0xa2, 0x3, 0x2, 0x1, 
0x0, 0xa3, 0x5, 0xa1, 0x3, 0x2, 0x1, 0x0, 0x6c, 0x8, 0xa3, 0x6, 0x2, 0x1, 0x8a, 
0x2, 0x1, 0x1};
Can you reformat the arrays so that they do not exceed the max. line length?



--
To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42745?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: libosmo-asn1-tcap
Gerrit-Branch: master
Gerrit-Change-Id: I5679c4a873176d73e973f5cfccff796fe6dbd941
Gerrit-Change-Number: 42745
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <[email protected]>
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Attention: lynxis lazus <[email protected]>
Gerrit-Comment-Date: Thu, 14 May 2026 13:03:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

Reply via email to