Attention is currently required from: dexter.

laforge has posted comments on this change by dexter. ( 
https://gerrit.osmocom.org/c/pysim/+/42741?usp=email )

Change subject: pySim/global_platform: make functionality available outside of 
cmd2
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

File pySim/global_platform/__init__.py:

https://gerrit.osmocom.org/c/pysim/+/42741/comment/511cc81a_ab412d9f?usp=email :
PS2, Line 1062: inst_perso_parser = argparse.ArgumentParser()
              :     inst_perso_parser.add_argument('application_aid', 
type=is_hexstr, help='Application AID')
              :
this doesn't look like it belongs here into the set_status method



--
To view, visit https://gerrit.osmocom.org/c/pysim/+/42741?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Idf4e4b58bf49ba62b2c22de4c49a2dcacfa872cb
Gerrit-Change-Number: 42741
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Attention: dexter <[email protected]>
Gerrit-Comment-Date: Wed, 13 May 2026 13:16:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

Reply via email to