Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42733?usp=email )
Change subject: cosmetic: remove excess linebreaks ...................................................................... Patch Set 1: Code-Review+1 (2 comments) File pySim-shell.py: https://gerrit.osmocom.org/c/pysim/+/42733/comment/690729c8_33315b07?usp=email : PS1, Line 1131: I think it's useful to sepaate the "main" block from class definitions with an extra line. Not sure why you think this needs our attention or "fixing". File pySim/transport/__init__.py: https://gerrit.osmocom.org/c/pysim/+/42733/comment/94822749_fa7eabef?usp=email : PS1, Line 28: I'm not quite sure what you are trying to achieve here. I think it's not uncommon to have an empty line to separate imporst from foreign modules to imports from within a project (pysim here). -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42733?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I2272abcdbba0e57c5118b69bc9398cd909a469b5 Gerrit-Change-Number: 42733 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Attention: dexter <[email protected]> Gerrit-Comment-Date: Thu, 07 May 2026 19:11:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
