Attention is currently required from: laforge, neels. fixeria has uploaded a new patch set (#5) to the change originally created by neels. ( https://gerrit.osmocom.org/c/pysim/+/42260?usp=email )
The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: ConfigurableParameter: safer val length check ...................................................................... ConfigurableParameter: safer val length check validate_val() calls len() to check the value against allow_len, min_len and max_len. len() requires the object to have a __len__() method, which integers do not — calling len() on an int raises TypeError. Fix this by checking for __len__ first: if present, use len(val) as usual; otherwise fall back to len(str(val)), which gives the number of decimal digits for integer values. Change-Id: Ibe91722ed1477b00d20ef5e4e7abd9068ff2f3e4 Jenkins: skip-card-test --- M pySim/esim/saip/personalization.py 1 file changed, 12 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/60/42260/5 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42260?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ibe91722ed1477b00d20ef5e4e7abd9068ff2f3e4 Gerrit-Change-Number: 42260 Gerrit-PatchSet: 5 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-Attention: neels <[email protected]> Gerrit-Attention: laforge <[email protected]>
