Attention is currently required from: pespin. Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmocore/+/42653?usp=email )
Change subject: vty: make CPU scheduling optional based on platform support ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/42653/comment/dcbf3972_6ccf200e?usp=email : PS1, Line 15: Also change osmo_cpu_sched_vty_init() to return int. > This would break ABI. […] The function osmo_cpu_sched_vty_init() is already implemented with return type int in cpu_sched_vty.c (see line 610). However, in the header file cpu_sched_vty.h it was incorrectly declared as returning void. This mismatch leads to inconsistent declarations across translation units. More strict compilers, such as Emscripten, reject this with an error, as they do not allow conflicting function signatures. So this change does not actually modify the ABI — it fixes the header to match the existing implementation. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42653?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic5b7e39fac16531d370cb81f769ba87fef18cb81 Gerrit-Change-Number: 42653 Gerrit-PatchSet: 1 Gerrit-Owner: Timur Davydov <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Sat, 25 Apr 2026 21:11:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]>
