Attention is currently required from: laforge, neels.

fixeria has posted comments on this change by neels. ( 
https://gerrit.osmocom.org/c/pysim/+/41771?usp=email )

Change subject: generate sdkey classes from a list
......................................................................


Patch Set 7:

(2 comments)

File pySim/esim/saip/personalization.py:

https://gerrit.osmocom.org/c/pysim/+/41771/comment/5995ef4b_3d396229?usp=email :
PS7, Line 653: reserved_kvn = tuple()
This is defined but never used anywhere?


https://gerrit.osmocom.org/c/pysim/+/41771/comment/c37bd825_bbf7ac93?usp=email :
PS7, Line 694: NO_OP = (('', {}))
Likewise, defined but not used.



--
To view, visit https://gerrit.osmocom.org/c/pysim/+/41771?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ic92ddea6e1fad8167ea75baf78ffc3eb419838c4
Gerrit-Change-Number: 41771
Gerrit-PatchSet: 7
Gerrit-Owner: neels <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-CC: fixeria <[email protected]>
Gerrit-Attention: neels <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Comment-Date: Sat, 25 Apr 2026 21:03:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

Reply via email to