Attention is currently required from: laforge, neels. fixeria has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/40209?usp=email )
Change subject: personalization audit: optionally audit all (unknown) SD keys ...................................................................... Patch Set 10: (1 comment) File pySim/esim/saip/batch.py: https://gerrit.osmocom.org/c/pysim/+/40209/comment/5a55c6ed_0dac2a2b?usp=email : PS10, Line 186: upp_audit[audit_key] = set((audit_val, )) Is it possible that the same KVN/ID combination appears in more than one SD PE? If so, the second occurrence silently replaces the first. We could handle this gracefully: ```suggestion upp_audit.add_values({audit_key: audit_val}) ``` -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40209?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Icaf6f7b589f117868633c0968a99f2f0252cf612 Gerrit-Change-Number: 40209 Gerrit-PatchSet: 10 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-Attention: neels <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Comment-Date: Fri, 24 Apr 2026 20:57:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
