Attention is currently required from: jolly, laforge.

laforge has posted comments on this change by jolly. ( 
https://gerrit.osmocom.org/c/osmo-remsim/+/42645?usp=email )

Change subject: Fix: Remove slot mapping at bankd when client disconnects
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

Patchset:

PS1:
I think this is fundamentally wrong. The slotmap is persistent state and under 
the exclusive control of the remsim-server.  There may very well be some state 
we need to clean up in the bankd, but we cannot delete the slotmap.  At that 
point, any new client connection would end up without a slotmap, as the slotmap 
is only added by remsim-server, and remsim-server has no idea the bankd just 
unilaterally decided to delete it.



--
To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42645?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-Change-Id: I2fd03490e2506c55104309a0ef952389119023b8
Gerrit-Change-Number: 42645
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: lynxis lazus <[email protected]>
Gerrit-Attention: jolly <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Comment-Date: Thu, 23 Apr 2026 15:40:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

Reply via email to