Attention is currently required from: lynxis lazus. jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-remsim/+/42664?usp=email )
Change subject: Fix: Prevent race conditions when accessing slotmap in bankd ...................................................................... Patch Set 2: (2 comments) File src/bankd/bankd_main.c: https://gerrit.osmocom.org/c/osmo-remsim/+/42664/comment/e087fccc_9b65b9ba?usp=email : PS1, Line 1115: slotmaps_rdlock(g_worker->bankd->slotmaps); > write lock? Done File src/slotmap.h: https://gerrit.osmocom.org/c/osmo-remsim/+/42664/comment/ac1c6be7_6b0fe04a?usp=email : PS1, Line 74: struct slot_mapping *slotmap_by_client(struct slotmaps *maps, const struct client_slot *client); > maybe add a postfix to the functions: _lock and _nolock? Done At least for the lookup functions. The delete function without locking already exists with the name _slotmap_del. -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42664?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I3464726f37beb7c47b4e1f00c018ffa4f3948906 Gerrit-Change-Number: 42664 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: lynxis lazus <[email protected]> Gerrit-Attention: lynxis lazus <[email protected]> Gerrit-Comment-Date: Thu, 23 Apr 2026 13:15:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: lynxis lazus <[email protected]>
