Attention is currently required from: fixeria. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ci/+/42661?usp=email )
Change subject: jobs/master-builds.yml: pysim: allow skipping card tests ...................................................................... Patch Set 2: Code-Review+1 (2 comments) Patchset: PS2: I think this is a good approach. In theory we could run another job on a more generic node first that checks if the job can be skipped, and then skip it in the pipeline... but that would make the pipeline longer and would be a lot more complex. File jobs/master-builds.yml: https://gerrit.osmocom.org/c/osmo-ci/+/42661/comment/48c63243_f6578481?usp=email : PS2, Line 653: {check_jenkins_mark} "skip-card-test" || {timeout_cmd} ./contrib/jenkins.sh We could print a specific string here when skipping the job. This could then be used in the script that generates the jenkins job to show that the job was skipped instead of linking to the log, so it is more obvious: https://gitea.osmocom.org/osmocom/osmo-ci/src/branch/master/scripts/jenkins-gerrit/comment_generate.py ```suggestion if {check_jenkins_mark} "skip-card-test"; then echo "GERRIT_PIPELINE_JOB_SKIPPED" else {timeout_cmd} ./contrib/jenkins.sh fi ``` -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42661?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I591717a2e2659c02447087dec23aa279cfd55551 Gerrit-Change-Number: 42661 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Thu, 23 Apr 2026 10:44:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
